Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #400 Rplt 400 dns records #11521

Merged
merged 36 commits into from
Mar 3, 2025
Merged

feat: #400 Rplt 400 dns records #11521

merged 36 commits into from
Mar 3, 2025

Conversation

bashleigh
Copy link
Contributor

@bashleigh bashleigh commented Feb 11, 2025

Customise DNS tab

Before the domain is configured, this is the page that will be displayed
Screenshot 2025-02-26 at 15 12 52

Customising domain modal

This modal is displayed when creating or editing the domain. The domain cannot be edited from the UI once the domain's TXT record value has been verified.
Screenshot 2025-02-26 at 15 13 03

Domain Verify

this step displays the TXT record name and value that will need to be added to the DNS by the developer. Once the record is added, they're able to hit the verify button to verify the TXT record exists. Using the edit button will show the previous modal
Screenshot 2025-02-26 at 15 13 08

Certificate DNS records

This step will display the certificate's DNS records created for this domain. The name and value will need to be added to their DNS for the certificate to work on that domain.
Screenshot 2025-02-26 at 15 13 39

Host CNAME

Once the certificate records are verified, the cloudfront distribution is displayed to the user to add to their DNS. Once the record is added the domain/subdomain will display the cloudfront distro's content
Screenshot 2025-02-26 at 15 14 16

Info page

Once the domain has been successfully configured, the pipeline info panel will display the custom domain opposed to the reapit generated sub domain.
Screenshot 2025-02-26 at 15 14 31

@bashleigh bashleigh force-pushed the RPLT-400-dns-records branch from 19636ec to f9137a7 Compare February 13, 2025 09:11
Copy link

codacy-production bot commented Feb 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5a8112d1 63.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5a8112d) Report Missing Report Missing Report Missing
Head commit (aca875a) 19833 16584 83.62%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11521) 263 167 63.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@bashleigh
Copy link
Contributor Author

ejs issue on codacy is blocked by this PR surma/rollup-plugin-off-main-thread#53
ejs has been resolved to 3.1.10 everywhere else except @surma/rollup-plugin-off-main-thread where ejs is resolved to 3.1.9.

@bashleigh bashleigh force-pushed the RPLT-400-dns-records branch from 9ea8a66 to 42913b1 Compare February 26, 2025 10:09
@plittlewood-rpt
Copy link
Contributor

As discussed, we should have a look at adding validation to ensure developers aren't trying to setup duplicate custom domains

@bashleigh bashleigh merged commit 10bfb9e into master Mar 3, 2025
9 of 11 checks passed
@bashleigh bashleigh deleted the RPLT-400-dns-records branch March 3, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants