-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #400 Rplt 400 dns records #11521
Conversation
19636ec
to
f9137a7
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
ejs issue on codacy is blocked by this PR surma/rollup-plugin-off-main-thread#53 |
9ea8a66
to
42913b1
Compare
As discussed, we should have a look at adding validation to ensure developers aren't trying to setup duplicate custom domains |
Customise DNS tab
Before the domain is configured, this is the page that will be displayed

Customising domain modal
This modal is displayed when creating or editing the domain. The domain cannot be edited from the UI once the domain's TXT record value has been verified.

Domain Verify
this step displays the TXT record name and value that will need to be added to the DNS by the developer. Once the record is added, they're able to hit the verify button to verify the TXT record exists. Using the edit button will show the previous modal

Certificate DNS records
This step will display the certificate's DNS records created for this domain. The name and value will need to be added to their DNS for the certificate to work on that domain.

Host CNAME
Once the certificate records are verified, the cloudfront distribution is displayed to the user to add to their DNS. Once the record is added the domain/subdomain will display the cloudfront distro's content

Info page
Once the domain has been successfully configured, the pipeline info panel will display the custom domain opposed to the reapit generated sub domain.
