feat: csv pagination download for mfa config #11623
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
| loading={isDownloading} | ||
| onClick={handleSetDownloading(setIsDownloading)} | ||
| onClick={() => | ||
| DownloadUsersCSVFunction({ |
There was a problem hiding this comment.
nit: functions should be camel case
| @@ -1,15 +1,6 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
would be good in the tests to check that the data you get from the function is what you expect it to be
|
|
||
| expect(setIsDownloading).toHaveBeenNthCalledWith(1, true) | ||
| expect(setIsDownloading).toHaveBeenNthCalledWith(2, false) | ||
| expect(global.fetch).toHaveBeenCalled() |
There was a problem hiding this comment.
would be good to check that it's fetching the expected thing(s) here
Pull request checklist
Detail as per issue below (required):
fixes: RPLT-1187