chore: replace security-header-lambda with native cloudfront responseheaderpolicy #11628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Contributor
|
Feel free to tell me where to go 😅 should we make it consistent, like you have or make it a construct to future proof it. Sorry in advance |
bashleigh
approved these changes
Oct 3, 2025
| ResponseHeadersPolicy, | ||
| } from 'aws-cdk-lib/aws-cloudfront' | ||
|
|
||
| const defaultContentSecurityPolicy = |
Contributor
There was a problem hiding this comment.
These differ between dev and prod. Is this catered for here?
Contributor
Author
There was a problem hiding this comment.
it's purposefully not, there shouldn't be any difference in config between prod and dev
plittlewood-rpt
requested changes
Oct 6, 2025
Contributor
plittlewood-rpt
left a comment
plittlewood-rpt
left a comment
There was a problem hiding this comment.
Can you let me know about dev/prod difference (see comment) before we merge this.
…f-security-header-lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs testing on dev
unit test fail is due to cognito-custom-mailer coverage so unrelated