Skip to content

Conversation

@re-taro
Copy link

@re-taro re-taro commented Apr 23, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #321

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 99f95da
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/6808e5f5fe2815000849fcb1
😎 Deploy Preview https://deploy-preview-322--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong but I don't believe this is the right fix.

The reason I believe this is because the camera is installed on the global threejs, this is installing it for each instance. What if there are 2 instances, then its double installed.

Also memo is used for referencing/storing pointers, this isn't storing anything so thats probably not the right approach.

@amcdnl
Copy link
Member

amcdnl commented Apr 24, 2025

After looking at your ticket, it looks like your issue is around SSR which makes since why this wouldn't work. SSR has no browser context on render, you moved the install of the browser controls to be runtime so thus eliminating the problem of not having browser context. Essentially we just need to say if browser then install otherwise skip.

@amcdnl amcdnl closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants