Add Aggregate Edges Functionality #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
amcdnl
reviewed
Jul 7, 2025
Member
amcdnl
left a comment
amcdnl
left a comment
There was a problem hiding this comment.
Would like to see if there might be a more optimized way to aggregate the edges using graphology library. If not, all good just want to make sure we think about that.
amcdnl
reviewed
Jul 8, 2025
| * @param labelType Label visibility type to determine if edge labels should be visible | ||
| * @returns Array of aggregated edges | ||
| */ | ||
| export const aggregateEdges = ( |
Member
There was a problem hiding this comment.
Minor but do we have any unit test coverage on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously, edges used to stack on top of each other when there were more than three edges between two nodes.
What is the new behavior?
Now, we can pass an optional
aggregateEdgesprop to aggregate edges that connect the same pair of nodes in both directions.Screen.Recording.2025-07-07.at.7.03.10.PM.mov
Does this PR introduce a breaking change?
Other information