Node Badges #347
Merged
Node Badges #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Badge component for displaying overlay information on graph nodes, such as counts or status indicators. The Badge component is designed to be positioned relative to nodes and supports customizable styling and animations.
- Adds a new Badge component with configurable colors, sizes, and positioning
- Creates comprehensive Storybook demos showcasing different Badge configurations
- Updates demo data to include count values for testing Badge functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/symbols/nodes/Badge.tsx | Main Badge component implementation with dynamic sizing and positioning |
| src/symbols/nodes/index.ts | Exports the new Badge component |
| stories/demos/Badge.story.tsx | Storybook demos showing Badge usage scenarios |
| stories/assets/demo.ts | Adds count data to demo nodes for Badge testing |
Comments suppressed due to low confidence (1)
src/symbols/nodes/Badge.tsx:42
- The default value of 1.5 for badgeSize is misleading since the prop description says it's a 'size multiplier relative to the node size', but looking at line 78, it's actually used as a multiplier. Consider renaming to 'sizeMultiplier' or updating the default to a more intuitive value like 0.25.
badgeSize = 1.5,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.