Concentric Layout #348
Merged
Concentric Layout #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new concentric layout system for graph visualization, providing two different implementations of concentric node positioning. The changes add support for both 2D and basic concentric layouts with customizable parameters like radius, spacing, and centrality-based positioning. Additionally, a new Badge component is introduced for displaying overlay information on nodes.
- Implements concentric2d layout with degree centrality-based positioning and configurable parameters
- Adds basic concentric layout with level-based node distribution
- Introduces Badge component for node annotations with customizable styling
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/demos/TwoLayouts.story.tsx | Adds Concentric story demo using range-generated nodes |
| stories/demos/Layouts.story.tsx | Adds Concentric2d story with layout configuration options |
| stories/demos/Badge.story.tsx | New story file demonstrating Badge component usage |
| src/symbols/nodes/index.ts | Exports new Badge component |
| src/symbols/nodes/Badge.tsx | New Badge component implementation |
| src/layout/types.ts | Adds concentric layout types to LayoutTypes union |
| src/layout/layoutProvider.ts | Integrates concentric layouts into layout provider |
| src/layout/index.ts | Exports concentric2d module |
| src/layout/concentric2d.ts | Implements 2D concentric layout with degree centrality |
| src/layout/concentric2d.test.ts | Unit tests for concentric2d layout |
| src/layout/concentric.ts | Implements basic concentric layout |
Comments suppressed due to low confidence (1)
src/symbols/nodes/Badge.tsx:43
- [nitpick] The default value of 2 for badgeSize is misleading as the parameter documentation describes it as a 'Size multiplier' but a value of 2 seems unusually large for a multiplier.
badgeSize = 2,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.