-
-
Notifications
You must be signed in to change notification settings - Fork 86
fix: update all major deps & some minor #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SerhiiTsybulskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amcdnl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SerhiiTsybulskyi - Can u pull this down and test it really well? If all is good, go ahead and release it.
|
4.28.0 tested locally, all seems fine (for our use case anyway). |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Updated all dependencies except
three-related andeslint-related (see specific commits for each major update).Each major's migration was followed to match previous behavior except for:
storybookwas migrated with built-in tool.rollup-plugin-peer-deps-externalwas removed in favor of a couple of loops using importedpackage.json.Build appears to output roughly same sizes as pre-migration (tiny bit smaller).
Sparse manual testing on storybook appears to be fine. Though a more knowledgeable dev should definitely check in more details (I'm only familiar-ish with a small subset of reagraph's features).
Updated workflows actions versions.
Updated workflows node versions to match that of the
package.json.Does this PR introduce a breaking change?
Node JS v20+ (engine requirement set to match latest from vite
^20.19.0 || >=22.12.0)Other information
Feel free to pick individual commits if you don't want to merge all in one PR.