Skip to content

Conversation

@Nerivec
Copy link
Contributor

@Nerivec Nerivec commented Jul 26, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Updated all dependencies except three-related and eslint-related (see specific commits for each major update).
Each major's migration was followed to match previous behavior except for:

storybook was migrated with built-in tool.
rollup-plugin-peer-deps-external was removed in favor of a couple of loops using imported package.json.

Build appears to output roughly same sizes as pre-migration (tiny bit smaller).

Sparse manual testing on storybook appears to be fine. Though a more knowledgeable dev should definitely check in more details (I'm only familiar-ish with a small subset of reagraph's features).

Updated workflows actions versions.
Updated workflows node versions to match that of the package.json.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Node JS v20+ (engine requirement set to match latest from vite ^20.19.0 || >=22.12.0)

Other information

Feel free to pick individual commits if you don't want to merge all in one PR.

@netlify
Copy link

netlify bot commented Jul 26, 2025

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit c68c0d7
🔍 Latest deploy log https://app.netlify.com/projects/reagraph/deploys/6889f7b209c7db0007912ec4
😎 Deploy Preview https://deploy-preview-351--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@SerhiiTsybulskyi SerhiiTsybulskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SerhiiTsybulskyi SerhiiTsybulskyi requested a review from amcdnl July 28, 2025 10:30
Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SerhiiTsybulskyi - Can u pull this down and test it really well? If all is good, go ahead and release it.

@SerhiiTsybulskyi SerhiiTsybulskyi merged commit eade575 into reaviz:master Aug 1, 2025
5 checks passed
@Nerivec Nerivec deleted the update-deps branch August 1, 2025 14:00
@Nerivec
Copy link
Contributor Author

Nerivec commented Aug 1, 2025

4.28.0 tested locally, all seems fine (for our use case anyway).
Nice deps cleanup for sure! https://github.com/Nerivec/zigbee2mqtt-windfront/pull/143/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants