Skip to content

Fix for the draggable nodes on the resized canvas #279 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcdnl merged 2 commits into from
Aug 11, 2025
Merged

Fix for the draggable nodes on the resized canvas #279 #359

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aedbcc
add size dependency to useDrag to force update of the position
AntonJames-Sistence Aug 7, 2025
edb2d59
add description to the fix
AntonJames-Sistence Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/useDrag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

const clientRect = useMemo(
() => gl.domElement.getBoundingClientRect(),
[gl.domElement]
[gl.domElement, size]

Check warning on line 49 in src/utils/useDrag.ts

View workflow job for this annotation

GitHub Actions / build 

React Hook useMemo has an unnecessary dependency: 'size'. Either exclude it or remove the dependency array
);

return useGesture(
Expand Down