ci: add GitHub Actions workflow for ARC CI testing #120

rebel-jaebin · 2025-10-20T09:25:31Z

🚀 Summary of Changes

What does this PR do? What feature, fix, or improvement does it bring?

This PR adds continuous integration infrastructure for vLLM-RBLN on ARC runners. It introduces a GitHub Actions workflow that builds containerized environments and runs automated tests to ensure code quality and correctness across different configurations.

📌 Related Issues / Tickets

Resolves #
Related to #

✅ Type of Change

✨ Feature (feature)
🧠 Model support (model)
🧬 Core engine changes (core)
🛠 Bug fix (bug-fix)
⚙️ Performance improvement (perf)
🔁 Refactor or code cleanup (refactor)
📄 Documentation (docs)
❓ Other (other): Continuous Integration infrastructure

🧪 How to Test

Run:

Trigger the workflow:
1. Open a pull request to trigger the CI automatically
2. Or manually trigger via workflow_dispatch with custom ref/Python version

Verify output:

Verify build step:
1. Check that the container image builds successfully
2. Verify dependency caching works (subsequent builds should skip if deps unchanged)

Verify test execution:
1. Confirm tests run in the containerized environment
2. Check test results

Edge case tested: ...

📸 Screenshots / Logs (if applicable)

📋 Checklist

PR title follows Conventional Commits format
This PR is linked to an existing issue
The test method is described, and the expected result is clearly stated
Relevant documentation has been updated (if applicable)

💬 Notes

Copilot

Pull Request Overview

This PR introduces a GitHub Actions CI workflow for vLLM-RBLN that runs on ARC runners with specialized hardware support. The workflow builds a containerized environment with necessary drivers (ATOM, BNXT RDMA) and dependencies, then executes automated tests to validate code changes.

Key changes:

Adds a multi-stage Dockerfile for building RBEL-optimized containers with hardware drivers
Implements dependency-based image caching to skip rebuilds when dependencies are unchanged
Creates a CI workflow with build and test jobs for pull request validation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
.github/workflows/rbln_arc_ci.yaml	Defines the CI pipeline with conditional image building and test execution
Dockerfile.ubi.ci	Multi-stage build for ATOM/BNXT drivers, Python environment, and vLLM-RBLN dependencies
entrypoint.sh	Container initialization script for driver setup and command execution

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Dockerfile.ubi.ci

.github/workflows/rbln_arc_ci.yaml

Dockerfile.ubi.ci

entrypoint.sh

Dockerfile.ubi.ci

rebel-jaebin · 2025-10-27T06:59:00Z

Thank you for your detailed review. I have reflected your feedback. @rebel-daekyeong

Dockerfile.ubi.ci

.github/workflows/rbln_arc_ci.yaml

Dockerfile.ubi.ci

rebel-jaebin · 2025-10-29T11:41:44Z

Hello @dtrifiro, I have a question regarding our next steps.
After the current PR is merged, what should we focus on next?
Are you planning to create test code for the vllm-rbln repository and open a PR for that?
I'd appreciate your guidance on what areas we should prioritize for support moving forward.
Thank you.

chr15p

The dockerfile looks good, I have some questions but nothing very serious.

chr15p · 2025-11-11T09:31:34Z

entrypoint.sh

+
+# Install RDMA packages (Oracle Linux repos are already configured in Dockerfile)
+dnf makecache \
+&& dnf install -y \


why are we installing all these packages at run time? everytime you run a container it will try and install these and maybe fail to run if it can't (if its in a disconnected environment for example)

why can we not install them in the dockerfile itself instead?

Because installing the RDMA-related packages in the Dockerfile caused issues where ibv_devices didn’t work properly, I updated the setup so that the packages are installed in entrypoint.sh instead.

chr15p · 2025-11-11T09:34:29Z

Dockerfile.ubi.ci

@@ -0,0 +1,169 @@
+ARG BASE_UBI_IMAGE_TAG=9.5


update this to ubi 9.6 maybe?

I see 9.7 came out today :)
There are lots of bug and security fixes that get rolled up into the new versions so its worth updating if you can.

chr15p · 2025-11-11T10:36:27Z

entrypoint.sh

+# Prepare host modules and udev triggers
+depmod -a "$(uname -r)" 2>/dev/null || true
+udevadm control --reload 2>/dev/null || true
+udevadm trigger 2>/dev/null || true


do we need to do these in the entrypoint ? if you run the image without root permissions they will fail and I dont understand why we need them.

These are the pieces of code that ensure the RDMA device is immediately usable.

The drivers should be loaded and configured by the operator and the device-plugin, vllm then uses the already configured devices.

depmod is creating a list of driver dependencies which should be fixed for any version of the driver, and is only used when the driver is loaded. So if we need to do it then it should really be done once by the operator when it loads the driver, rather than every time we start a new instance of vllm.

I will reflect the parts you mentioned in the additional PR.
Thank you for your detailed review.

tsailiming · 2025-11-11T12:20:04Z

Dockerfile.ubi.ci

+baseurl=https://yum.oracle.com/repo/OracleLinux/OL9/appstream/x86_64/
+enabled=1
+gpgcheck=0
+EOF


Is there a reason to use OL9 when using UBI image?

What are the additional packages you need?

the only package that is not available in the default ubi repos is numactl-devel if you dont need this that you can get rid of the oracle repos entirely. As an alternative numactl-libs is available which includes the runtime numactl libraries, just not the header files to compile against.

In the CI stage, we recompile vLLM by using the --no-binary option.
Even when building the CPU version, numa.h is required, so I install numactl-devel.

As @chr15p mentioned earlier, this package is not available in the default UBI repository, so I added an additional repo.

related error message

/root/.cache/uv/sdists-v9/pypi/vllm/0.10.2/-ni3cE3hJbPJ1ceUT2JNz/src/csrc/cpu/utils.cpp:2:12: fatal error: numa.h: No such file or directory 2 | #include <numa.h> | ^~~~~~~~

https://github.com/vllm-project/vllm/blob/main/csrc/cpu/utils.cpp

tsailiming · 2025-11-11T12:21:55Z

Dockerfile.ubi.ci

+    ./configure && \
+    make clean && \
+    make && \
+    make install


What are these broadcom drivers used for?

Broadcom drivers are used for RDMA.

chr15p

not a problem I'm just wondering why you structure the dockerfile this way

dtrifiro · 2025-11-11T16:30:42Z

Dockerfile.ubi.ci

+RUN chmod +x /entrypoint.sh
+ENTRYPOINT [ "/entrypoint.sh" ]
+
+CMD ["/bin/bash"]


We should avoid running as the root user. Something like this works well for openshift:

# setup non-root user for OpenShift RUN umask 002 && \ useradd --uid 2000 --gid 0 vllm && \ mkdir -p /home/vllm && \ chmod g+rwx /home/vllm USER 2000

This change could cause permission issues in other locations, so this needs to be validated.

dtrifiro · 2025-11-11T16:31:41Z

entrypoint.sh

+dnf makecache \
+&& dnf install -y \
+    rdma-core \
+    librdmacm \
+    libibverbs \
+    libibverbs-utils \
+    infiniband-diags \
+    pciutils \
+    kmod \
+&& dnf clean all 


As @chr15p mentioned, we shouldn't be installing these at runtime, also, this requires the container to run as root, see my above comment.

If we need root permissions in order to run depmod (shouldn't the operator be taking care of this though?), we need some mechanism to drop permissions before running vllm as well.

rebel-jaebin · 2025-11-13T12:21:09Z

@chr15p @dtrifiro @tsailiming

Rebellions will provide an NPU Operator that installs the device driver and related software.
However, since the NPU Operator is still under development, these components must currently be installed manually.
Therefore, most of the NPU-related software installation steps currently included in the Dockerfile will eventually be removed.
RDMA is an important feature for vLLM-RBLN, which uses RBLN-CCL for performance in DP, TP, PP, EP, and P/D (Prefill/Decode Disaggregation).
As a result, many code additions were made to ensure RDMA support.

I wanted to share this background context.

It seems the root-privilege issue needs to be fixed.
Thank you.

rebel-jonghewk · 2025-11-19T04:02:27Z

pyproject.toml

+    "rebel-compiler==0.9.3.dev120+gd2b492be",
+    "triton-rbln==3.2.0+rbln.git617682d1",


why do you need this depedencies?

We use these dependencies to develop our internal functions.
Additionally, i will add a commit to ensure that the above dependencies are installed only when given the option to not affect the main branch.

That would be great.

rebel-jaebin · 2025-11-19T12:33:09Z

To all reviewers

The current PR will be merged once CI is approved.
Anything not reflected in the current PR will be reflected in a subsequent PR.
Thank you.

rebel-jaebin self-assigned this Oct 21, 2025

rebel-jiwoopark changed the base branch from main to dev October 21, 2025 04:59

rebel-jaebin force-pushed the feature/arc-ci branch 8 times, most recently from 6098926 to e120860 Compare October 23, 2025 07:58

rebel-jaebin requested review from rebel-daekyeong, rebel-jinmoo and rebel-minwook October 23, 2025 11:33

rebel-jaebin force-pushed the feature/arc-ci branch from 173b959 to 6607573 Compare October 24, 2025 07:49

rebel-daekyeong requested a review from Copilot October 24, 2025 08:32

Copilot AI reviewed Oct 24, 2025

View reviewed changes

rebel-jaebin force-pushed the feature/arc-ci branch from 6607573 to a6e4268 Compare October 24, 2025 08:42

rebel-daekyeong reviewed Oct 24, 2025

View reviewed changes

rebel-jaebin force-pushed the feature/arc-ci branch 4 times, most recently from 3214b52 to 730e6ae Compare October 27, 2025 07:46

rebel-jaebin requested a review from rebel-daekyeong October 27, 2025 08:21

dtrifiro reviewed Oct 27, 2025

View reviewed changes

Dockerfile.ubi.ci Outdated Show resolved Hide resolved

dtrifiro reviewed Oct 27, 2025

View reviewed changes

.github/workflows/rbln_arc_ci.yaml Show resolved Hide resolved

rebel-jaebin requested a review from dtrifiro October 27, 2025 11:17

dtrifiro reviewed Oct 27, 2025

View reviewed changes

.github/workflows/rbln_arc_ci.yaml Outdated Show resolved Hide resolved

dtrifiro reviewed Oct 27, 2025

View reviewed changes

Dockerfile.ubi.ci Outdated Show resolved Hide resolved

rebel-jaebin added 5 commits November 3, 2025 12:00

Add files for CI

85420a9

Reflect comments

94ef332

Update python version 3.10.12 to 3.12.9

8eb1832

Update python install method

f9d6c41

Update triton-rbln version

0ccf25e

rebel-jaebin force-pushed the feature/arc-ci branch 3 times, most recently from f5234b9 to 5bf7abd Compare November 6, 2025 10:52

Migrate to uv package manager with secure private index configuration

4e94400

rebel-jaebin force-pushed the feature/arc-ci branch from 5bf7abd to 4e94400 Compare November 6, 2025 10:54

Update activating venv

68d606c

rebel-jaebin force-pushed the feature/arc-ci branch from 2944d95 to 68d606c Compare November 6, 2025 11:36

Update uv cache disabled

4abfefe

chr15p reviewed Nov 11, 2025

View reviewed changes

tsailiming reviewed Nov 11, 2025

View reviewed changes

chr15p reviewed Nov 11, 2025

View reviewed changes

dtrifiro reviewed Nov 11, 2025

View reviewed changes

rebel-jaebin added 2 commits November 17, 2025 20:26

Update UBI version

f2a706f

Update depencencies

cc78b65

rebel-jaebin requested review from rebel-jiwoopark, rebel-jonghewk, rebel-shshin and rebel-sunwook November 18, 2025 08:36

rebel-jonghewk reviewed Nov 19, 2025

View reviewed changes

Update python dependency management strategy

71d014f

		"rebel-compiler==0.9.3.dev120+gd2b492be",
		"triton-rbln==3.2.0+rbln.git617682d1",

ci: add GitHub Actions workflow for ARC CI testing #120

Are you sure you want to change the base?

ci: add GitHub Actions workflow for ARC CI testing #120

Conversation

rebel-jaebin commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Summary of Changes

📌 Related Issues / Tickets

✅ Type of Change

🧪 How to Test

📸 Screenshots / Logs (if applicable)

📋 Checklist

💬 Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rebel-jaebin commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rebel-jaebin commented Oct 29, 2025

Uh oh!

chr15p left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rebel-jaebin Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chr15p Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rebel-jaebin commented Oct 20, 2025 •

edited

Loading

rebel-jaebin Nov 13, 2025 •

edited

Loading

chr15p Nov 13, 2025 •

edited

Loading

rebel-jaebin Nov 13, 2025 •

edited

Loading

chr15p left a comment •

edited

Loading