(WIP) feat(core): allow multiple prefill requests to be scheduled in a chunk #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Summary of Changes
📌 Related Issues / Tickets
✅ Type of Change
feature)model)core)bug-fix)perf)refactor)docs)other): please describe🧪 How to Test
With this branch, the overall process of multiple-prefills-in-a-chunk, including the inputs for the prefill attention kernel, can be analyzed. I guess the values for
slot_mappingcan be modified depending on the kernel implementation.RBLN_KERNEL_MODE=triton USE_VLLM_MODEL=1 VLLM_DISABLE_COMPILE_CACHE=1 USE_VLLM_V1=0 FLASH_CAUSAL_ATTN=0 python examples/experimental/offline_inference_basic.pyRunning with
FLASH_CAUSAL_ATTN, which is the default, will use the original scheduling policy where only 1 prefill request is scheduled at a time.📸 Screenshots / Logs (if applicable)
📋 Checklist
💬 Notes
In the previous meeting, I've shared some outputs generated by this feature implementation, which indicates that it ran without errors even though the functionality was incorrect. Those results can be reproduced with earlier versions of the compiler/kernels. With the recent versions, it seems that the prefill attention kernel simply raises an error. Please refer to this note for the results obtained with earlier versions of the compiler/kernels.