Tolerate ClickHouse startup connection failures#320
Merged
Conversation
Provide now logs a warning and supplies a nil *Batcher instead of returning an error when the connection can't be opened, so an unreachable ClickHouse never blocks server startup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
der-eismann
approved these changes
Jun 9, 2026
bjoernhaeuser
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unreachable ClickHouse at startup currently fails the whole server boot. This makes analytics best-effort: if the connection can't be opened,
chutil.Providelogs a warning and supplies a nil*Batcher(skipping the worker loop) instead of returning an error, so the server starts regardless.🤖 Generated with Claude Code