fix: update rewarder implementation #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: avichalp <[email protected]>
Signed-off-by: avichalp <[email protected]>
Signed-off-by: avichalp <[email protected]>
Signed-off-by: avichalp <[email protected]>
Signed-off-by: avichalp <[email protected]>
Signed-off-by: avichalp <[email protected]>
avichalp
commented
Apr 11, 2025
|
|
||
| event ActiveStateChange(bool active, address account); | ||
| event SubnetUpdated(SubnetID subnet, uint256 checkpointPeriod); | ||
| event SubnetUpdated(SubnetID subnet); |
Collaborator
Author
There was a problem hiding this comment.
Stop storing checkpointPeriod, we will fetch the number of blocks in a checkpoint on the fly
avichalp
commented
Apr 11, 2025
| /// @dev Ensures the checkpoint height is a multiple of the checkpoint period | ||
| function validateCheckpointHeight(uint64 claimedCheckpointHeight) internal view returns (bool) { | ||
| return claimedCheckpointHeight > 0 && claimedCheckpointHeight % checkpointPeriod == 0; | ||
| /// @notice Gets the number of blocks in a checkpoint from the subnet actor |
Collaborator
Author
There was a problem hiding this comment.
Calls the subnetActorGetter to fetch the number of blocks in the checkpoint.
avichalp
commented
Apr 11, 2025
| } | ||
|
|
||
| /// @notice A bottom-up checkpoint type. | ||
| struct BottomUpCheckpoint { |
Collaborator
Author
There was a problem hiding this comment.
Addition data types copied over from IPC contracts to call subnetGetterActor
carsonfarmer
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
ValidatorRewardercontract and related scripts and tests. The changes focus on improving the accuracy of reward calculations.In the earlier implementation we mistakenly assumed that every bottom-up checkpoint will always be 600 blocks (checkpoint period). This assumption is wrong. Bottom up checkpoints in IPC can be shorter than the checkpoint period. Sometimes when the max number of messages are added the checkpoint is sent immediately.
These changes reads the actual number of blocks in the checkpoint and use that number for reward calculation. For instance, if any checkpoint contains only 300 blocks then the rewards claimed by the validator should be: 100 * validator's share.
closes: #100