Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: axelar support #18

Merged
merged 11 commits into from
Oct 21, 2024
Merged

feat: axelar support #18

merged 11 commits into from
Oct 21, 2024

Conversation

oed
Copy link
Contributor

@oed oed commented Sep 26, 2024

This PR adds support for Axelars Interchain Token Service to our ERC20 token. Our ERC20 is kept upgradable such that we can add/remove bridges over time (e.g. we are not locked into axelar).

The deploy script has been set up to connect the token to the axelar bridge on deploytime.

Deployed a test version of the token on Filecoin so far, which can be viewed on Axelars bridge app.
Waiting for gasprices on Ethereum to lower a bit before I deploy there, after which the bridging can be tested.

In addition to the bridge functionality I noticed that the ERC20 was importing PausableUpgradeable, but wasn't actually overriding any of the ERC20 methods to make them respect pausing. Fixed this.

@oed oed requested review from ukstv and carsonfarmer September 26, 2024 18:01
@oed oed self-assigned this Sep 26, 2024
@oed oed requested a review from JulissaDantes October 10, 2024 10:54
@oed oed marked this pull request as ready for review October 10, 2024 10:55
@sanderpick
Copy link
Member

@oed is this one ready for review/merge?

@oed
Copy link
Contributor Author

oed commented Oct 15, 2024

@sanderpick yes!

Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of comments but overall LGTM, let's see what others have to say.

Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. lgtm

@oed oed changed the title Feat/axelar support feat: Axelar support Oct 21, 2024
@oed oed changed the title feat: Axelar support feat: axelar support Oct 21, 2024
@oed oed merged commit b299ff0 into main Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants