feat: validator gater contract #19
Conversation
Signed-off-by: Sander Pick <[email protected]>
sanderpick
force-pushed
the
sander/validator-gater
branch
from
093e171 to
6ef42de
Compare
Signed-off-by: Sander Pick <[email protected]>
|
Should |
|
@avichalp @sanderpick could you review this? |
lib/forge-std
Outdated
There was a problem hiding this comment.
curious, why are these changing?
| // SPDX-License-Identifier: UNLICENSED | ||
| pragma solidity ^0.8.23; | ||
| // SPDX-License-Identifier: MIT OR Apache-2.0 | ||
| pragma solidity ^0.8.26; |
There was a problem hiding this comment.
on reflection, maybe 0.8.23 is enough? i don't have a real opinion here
test/ValidatorGater.t.sol
Outdated
|
|
||
| SubnetID public subnet; | ||
| mapping(address => PowerRange) public allowed; | ||
| // New active status and who was the owner at change time |
There was a problem hiding this comment.
nit: spacing below comment
|
|
||
| /// @notice Sets the contract as active or inactive. | ||
| /// @dev Only the owner can change the active state. | ||
| function setActive(bool active) external onlyOwner { |
|
|
||
| modifier whenActive() { | ||
| if (!_active) { | ||
| return; // Skip execution if not active |
There was a problem hiding this comment.
does this just fail the txn? if so, that might not work because when we toggle this to inactive, the subnet contracts will still make calls to it when somebody joins and those calls should succeed. e.g., isAllow should just return true for everyone when the "gate" is "inactive".
There was a problem hiding this comment.
No it wont revert, it just returns without running the code in the gater function using this modifier.
There was a problem hiding this comment.
oh right, i forgot how the modifiers work 👍
|
@dtbuchholz can you 👍 this PR? I can't do it because I opened it originally. |
Adds a validator gater contract, follow this https://github.com/consensus-shipyard/ipc/blob/main/docs/ipc/validator-gater.md. This is more or less the same as the example contract from https://github.com/consensus-shipyard/ipc/blob/main/contracts/contracts/examples/SubnetValidatorGater.sol with foundry tooling.
Also cleans up solidity pragma and license inconsistencies.