fix: address audit feedback #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
approved these changes
Jan 24, 2025
| /// @dev The rate is expressed as a decimal*1e18. | ||
| /// @dev For example 5% APY is 0.0000928276004952% yield per checkpoint period. | ||
| /// @dev This is expressed as 928_276_004_952 or 0.000000928276004952*1e18. | ||
| uint256 public constant INFLATION_RATE = 928_276_004_952; |
There was a problem hiding this comment.
We made this a constant because we expect to just replace the validatorRewarder if we want to change the rate?
There was a problem hiding this comment.
yes, we could just replace the contract. also we need to reimplement this contract based on @carsonfarmer's new, simplified proposal #59
Signed-off-by: avichalp <[email protected]>
Signed-off-by: avichalp <[email protected]>
avichalp
force-pushed
the
avichalp/audit-feedback
branch
from
9aca62f to
5ecdb97
Compare
sanderpick
pushed a commit
that referenced
this pull request
Jan 26, 2025
Implement changes in the existing contracts as proposed in #47 audit feedback. Signed-off-by: avichalp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement changes in the existing contracts as proposed in the #47