fix: miscellaneous #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtbuchholz
approved these changes
Jan 29, 2025
ukstv
approved these changes
Jan 29, 2025
avichalp
reviewed
Jan 29, 2025
src/token/Recall.sol
Outdated
| @@ -112,6 +108,7 @@ contract Recall is | |||
| { | |||
| uint256 _allowance = allowance(sender, spender); | |||
| if (_allowance != type(uint256).max) { | |||
| require(_allowance >= amount, "ERC20: insufficient allowance"); | |||
There was a problem hiding this comment.
might be good to use a custom error? because we are not using requires in other contracts for assertions. but nbd
There was a problem hiding this comment.
iirc we have solhint warning if you use require, and I previously went through and converted everything to use explicit errors. so I agree...keep it consistent
There was a problem hiding this comment.
Throws an error now, all good?
dtbuchholz
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recallnet/ipc#488