fix: pausing & unpausing have the same role #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
changed the title
oed
force-pushed
the
fix/unpausing
branch
2 times, most recently
from
1797dc0 to
af0b62b
Compare
dtbuchholz
approved these changes
Jan 29, 2025
|
@oed just to confirm: we do not follow the suggestion to implement a custom UNPAUSER role, right? Just to say it out loud. |
ukstv
approved these changes
Jan 29, 2025
|
@ukstv the recommendation was "Keep ADMIN_ROLE or create a separate UNPAUSER_ROLE for unpause functionality" so we are following it. We can create an additional if you think that would be valuable? |
|
God. I created confusion. No, it is all right. It makes sense to leave it as it is. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recallnet/ipc#487