fix: include machine kind in machine events #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sander Pick <[email protected]>
sanderpick
commented
Feb 19, 2025
There was a problem hiding this comment.
kind is indexed so you can filter on it from viem / other libs
dtbuchholz
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
lgtm. @sanderpick will the new testnet reflect these changes? or should i use the existing event MachineInitialized(address machineAddress) that's emitted?
we're going to publish the js packages whenever the new testnet is up, so i wanna make sure they use the correct one.
|
this will have to wait until the next reset |
sanderpick
added a commit
to recallnet/ipc
that referenced
this pull request
Feb 19, 2025
Turns out I forgot that the `MachineState` trait has a method `kind()` that returns the underlying state's `Kind`. So, this is easy. Depends on recallnet/contracts#83 Signed-off-by: Sander Pick <[email protected]>
islamaliev
pushed a commit
to recallnet/ipc
that referenced
this pull request
Feb 21, 2025
Turns out I forgot that the `MachineState` trait has a method `kind()` that returns the underlying state's `Kind`. So, this is easy. Depends on recallnet/contracts#83 Signed-off-by: Sander Pick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So downstream tools can filter on machine kind.