Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update set config event #84

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

avichalp
Copy link
Member

Updates set config events related to recallnet/ipc#522

Signed-off-by: avichalp <[email protected]>
@avichalp avichalp changed the title update set config event fix: update set config event Feb 20, 2025
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dtbuchholz are we okay to just keep making changes here? i see some tags on this repo... are those used for versioning by the JS repo?

@dtbuchholz
Copy link
Contributor

dtbuchholz commented Feb 20, 2025

@sanderpick huh, idk why tags are being added or when that started occurring. afaik, no, those tags arent used anywhere.

the js repo uses this contracts repo as a submodule—no tags used

@sanderpick
Copy link
Member

maybe @sam701 or @joewagner added the tags? it would be nice if this repo published an NPM package with JS bindings, similar to what we did in evm-tableland. ie, tag and publish w/ a job: https://github.com/tablelandnetwork/evm-tableland/blob/main/.github/workflows/publish.yml

@dtbuchholz
Copy link
Contributor

this is the js-recall package, for reference—we could definitely migrate it over here: https://github.com/recallnet/js-recall/tree/main/packages/contracts.

@sanderpick
Copy link
Member

oh i see. nah i think what you did is good. just so long as there is a way we can continue to push to this repo and not break the JS tooling

@joewagner
Copy link
Contributor

joewagner commented Feb 20, 2025

maybe @sam701 or @joewagner added the tags? it would be nice if this repo published an NPM package with JS bindings, similar to what we did in evm-tableland. ie, tag and publish w/ a job: https://github.com/tablelandnetwork/evm-tableland/blob/main/.github/workflows/publish.yml

I didn't add any tags here, but using tags to keep things clear sounds like a reasonable idea. For example, whatever version commit hash is being used in the js-recall submodule would have a tag (in this repo).

@sam701
Copy link

sam701 commented Feb 20, 2025

@sanderpick yes, I tag all our repos on every subnet reset, as we defined in the subnet reset process in notion.

@avichalp avichalp merged commit 19c8b09 into main Feb 21, 2025
7 of 8 checks passed
@avichalp avichalp deleted the avichalp/update-config-event branch February 21, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants