-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update set config event #84
Conversation
Signed-off-by: avichalp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@dtbuchholz are we okay to just keep making changes here? i see some tags on this repo... are those used for versioning by the JS repo?
@sanderpick huh, idk why tags are being added or when that started occurring. afaik, no, those tags arent used anywhere. the js repo uses this |
maybe @sam701 or @joewagner added the tags? it would be nice if this repo published an NPM package with JS bindings, similar to what we did in |
this is the |
oh i see. nah i think what you did is good. just so long as there is a way we can continue to push to this repo and not break the JS tooling |
I didn't add any tags here, but using tags to keep things clear sounds like a reasonable idea. For example, whatever version commit hash is being used in the js-recall submodule would have a tag (in this repo). |
@sanderpick yes, I tag all our repos on every subnet reset, as we defined in the subnet reset process in notion. |
Updates set config events related to recallnet/ipc#522