-
Notifications
You must be signed in to change notification settings - Fork 45
Remove unneeded serialization #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -39,17 +39,7 @@ export const getPredictions = base | |||||
| input.competitionId, | ||||||
| ); | ||||||
|
|
||||||
| return { | ||||||
| predictions: predictions.map((p) => ({ | ||||||
| id: p.id, | ||||||
| agentId: p.agentId, | ||||||
| agentName: p.agentName ?? null, | ||||||
| predictedWinner: p.predictedWinner, | ||||||
| confidence: p.confidence, | ||||||
| reason: p.reason, | ||||||
| createdAt: p.createdAt.toISOString(), | ||||||
| })), | ||||||
| }; | ||||||
| return predictions; | ||||||
|
||||||
| return predictions; | |
| return { predictions }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return structure has changed from an object with a
gameproperty to returning the game object directly. This is a breaking change that will cause existing E2E tests to fail. The tests inapps/comps/e2e/tests/nfl-competition.test.tsexpect to accessdata.game(lines 664, 852, 853), but this change makes the game object the top-level return value.If this breaking change is intentional, the E2E tests need to be updated accordingly. If not, the return structure should be preserved as
{ game }for backward compatibility.