Fix/kbd occlusion hardening - #40
Merged
Merged
Conversation
Signed-off-by: kryptocodes <srivatsantb@gmail.com>
Signed-off-by: kryptocodes <srivatsantb@gmail.com>
Signed-off-by: kryptocodes <srivatsantb@gmail.com>
Signed-off-by: kryptocodes <srivatsantb@gmail.com>
Signed-off-by: kryptocodes <srivatsantb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mobile keyboard/input hardening in
images/minimal-vnc-desktop, plus health reporting for the embed chain (customer page → portal → liveview).Keyboard/geometry
rotation, letterbox and long-press (
kbd/fit.js,kbd/tap.js,kbd/viewport-transform.js).embedded fallback measurer that sees no occlusion stays silent. Misconfigured embedders now
get no help instead of no lift.
{type:'parent-viewport'}is translated toPOPCORN_HOST_GEOMETRY, so the deployedportal works unmodified. Opt out:
attach(frame, { legacyGeometry: false }).Embed contract
PopcornHost.layer()now relayouts a fresh iframe. The liveness guard tripped on the blankcontentDocumentevery parsed iframe owns, so the documented recipe was refused.auditLayout()+.on('layout'|'scale'|'health')report structural codes(
host-geometry-blind/-stale/-disagrees,focus-stolen,no-virtual-keyboard,remote-unconfirmed) up the bridge and into the pod-side log.host/test-host.html:?badlayout=1,&nest=1,?legacybridge=1,&legacyxlate=0reproduce each failure.
Desktop / proxy
proxy/emulate.go).GET /kbdstateHTTP fallback while the/kbdsocket connects.come from measured RTT, replacing
?motionq=1.Opt-in
?fbscale=auto|1|2|3supersampled framebuffer, default1= off (costs k² pixels/frame).?e2e=1input→paint traces (needsdiag=1), capped at 8 per load.Test count went 0 → 413 plus a real-browser contract check, so most of +7.4k lines is tests
and README.
Validation
Risk and Rollback
fbscale=1,e2e/diagopt-in.occludedBottom: 0will now see the viewer's detectors run./kbdstateis read-only, behind the same readiness gate as/kbd, structural state only.main. No schema or cross-service changes.Checklist