feat: add optional LiveView end-to-end encryption - #43
Merged
Merged
Conversation
Contributor
Author
|
Addressed findings 2–6 in
Verification completed:
|
kryptocodes
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liveViewEncryption: "e2e"session creation while keeping the standard transport as the defaultData flow
The gateway forwards encrypted LiveView frames and observes connection metadata, frame sizes, and timing. The client and pod decrypt message contents. Redis stores session-to-pod route metadata.
CDP remains available for Playwright and server automation through authenticated WSS. The gateway terminates TLS for CDP, session status, and TTL requests.
Verification
cd services/control-plane && bun test(92 passed)cd services/pool-manager && bun test(36 passed)cd packages/trusted-liveview && npm test(12 passed)cd packages/trusted-liveview && npm run build:checkcd images/minimal-vnc-desktop/proxy && go test -race ./..../images/minimal-vnc-desktop/build.sh