feat(mcp): add caller nonces and independent attestation verification - #80
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
AbdulRashidReshamwala
force-pushed
the
codex/mcp-agent-verification
branch
from
September 9, 2026 23:11
26f3978 to
51acba7
Compare
kryptocodes
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Agents could retrieve an attestation document but could not supply their own challenge, and
attested: truedescribed successful retrieval rather than independent verification. Require a caller-generated nonce and provide a verifier that runs locally against separately trusted deployment policy.Changes:
verify_runtimerequires a fresh 32-byte caller nonce, encoded as 64 lowercase hex characters. Missing or invalid challenges fail before any request; there is no server-generated fallback.attestedwithevidence_availableandverification.status: "not_performed". Return fixed Google discovery/JWKS references, expected claims, the image-binding algorithm, policy requirements, and claims established by successful verification.Compatibility: this changes the MCP tool contract. Clients must refresh tool discovery, supply a nonce, and consume the replacement output fields. The hosted service is not deployed by this PR.
Validation:
PR Type
Enhancement, Tests, Documentation
Description
Require caller-generated nonce for runtime evidence retrieval
Replace retrieval-based attestation status with evidence availability
Add independent Google RS256 proof verifier
Document trusted policy requirements and verification limits
Diagram Walkthrough
File Walkthrough
4 files
Test nonce-required runtime evidence tool contractTest caller nonce evidence retrieval behaviorRun independent attestation verifier testsTest signature claims policy and bindings4 files
Define nonce validation and verification guidanceRetrieve runtime proofs using caller nonceUpdate runtime verification tool schema and outputAdd local Google attestation proof verifier2 files
Document independent proof verification workflowDocument breaking runtime verification contract