Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding QuickJS Javascript Engine deobfuscator Dependency #1485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phisher98
Copy link
Contributor

No description provided.

@phisher98
Copy link
Contributor Author

phisher98 commented Jan 13, 2025

Logcat to if added in Gradle extension-wise doesn't work

  W  java.lang.NoClassDefFoundError: Failed resolution of: Lapp/cash/quickjs/QuickJs;
  W      at recloudstream.InvidiousProvider.getMainPage(InvidiousProvider.kt:34)
  W      at recloudstream.InvidiousProvider$getMainPage$1.invokeSuspend(Unknown Source:16)
  W      at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
  W      at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
  W      at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
  W      at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:832)
  W      at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
  W      at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)
  W  Caused by: java.lang.ClassNotFoundException: Didn't find class "app.cash.quickjs.QuickJs" on path: DexPathList[[zip file "/storage/emulated/0/Cloudstream3/plugins/InvidiousProvider.cs3"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64]]
  W      at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:218)
  W      at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
  W      at java.lang.ClassLoader.loadClass(ClassLoader.java:312)

@phisher98 phisher98 changed the title Adding QuickJS Javascript Engine deobfuscator 1st Phase Adding QuickJS Javascript Engine deobfuscator Dependency Jan 14, 2025
@fire-light42
Copy link
Collaborator

A better javascript interpreter is great, however I would like rhino to be marked as deprecated (and a new similar function is added) if we are to introduce another dependency doing the same job.
I am referring to this function.
It does not have to be the same function, but something which makes QuickJs easy to use for extension developers.

If this is urgent that can be a separate pull request.

@phisher98
Copy link
Contributor Author

It's not doing same Job it's just able to perform more than rhino and if we remove rhino it could break extension still using it

I have tried to create a fun for it but no luck yet so I have added Decryptor extension wise but it's asking dependency to be added on app side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants