fix: query GPU memory with torch first#2349
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
f149503 to
c063d44
Compare
Contributor
Author
|
I checked the red GPU shards. The CPU/Spark groups passed, and the GPU jobs fail before tests run because the external GPU worker setup cannot provide a usable device: repeated cloud allocation errors are followed by \No devices were found\ and exit code 6. This does not appear to be caused by the code change. Could the failed GPU jobs be rerun when capacity is available? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.cuda.mem_get_info()forget_gpu_info()when PyTorch can see CUDA devicesWhy
Issue #2344 shows
get_gpu_info()can trip a numba CUDA context error while collecting GPU memory.get_number_gpus()already tries torch first, so this makesget_gpu_info()follow the same safer path and avoids creating a numba context when torch already has the data.To verify
python -m py_compile recommenders\utils\gpu_utils.py tests\unit\recommenders\utils\test_gpu_utils.py.\.venv312\Scripts\python.exe -m pytest tests\unit\recommenders\utils\test_gpu_utils.py::test_get_gpu_info_uses_torch_cuda tests\unit\recommenders\utils\test_gpu_utils.py::test_get_number_gpus_without_torch -qgit diff --cached --checkbefore commit