Skip to content

docs: label MAP@k notebook outputs consistently#2350

Open
he-yufeng wants to merge 1 commit into
recommenders-team:stagingfrom
he-yufeng:fix/map-at-k-reporting-staging
Open

docs: label MAP@k notebook outputs consistently#2350
he-yufeng wants to merge 1 commit into
recommenders-team:stagingfrom
he-yufeng:fix/map-at-k-reporting-staging

Conversation

@he-yufeng

Copy link
Copy Markdown
Contributor

Description

Follow-up for #2309 after #2316 moved the metric calculation to map_at_k().

A few notebooks still displayed the resulting map_at_k() value as plain MAP or Mean average precision, which makes the output look like the non-@k metric even though the code is already computing MAP@k. This PR only updates those labels to MAP@K / MAP@k and fixes one broken markdown link in the same operationalization notebook paragraph.

Related Issues

Fixes #2309.

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Validation:

  • Parsed the five changed notebooks as JSON.
  • Ran git diff --check.
  • Did not re-run the notebooks; the changes are stored output/source label updates only.

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant