-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
186 confusing reconcile route for reconciliation service #187
186 confusing reconcile route for reconciliation service #187
Conversation
✅ Deploy Preview for reconciliation-api-specs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
Co-authored-by: Antonin Delpeuch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The match
terminology fits in well with existing concepts and fields like matching features, matchType, matchQuantifier, matchQualifier etc. Added one inline suggestion to change the header for the service section.
Renamed to section to Match Service Co-authored-by: Fabian Steeg <[email protected]>
replaced the route /reconcile with /match and updated text to introduce the match service as the primary role of a reconciliation service. closes #186