Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186 confusing reconcile route for reconciliation service #187

Merged

Conversation

saumier
Copy link
Contributor

@saumier saumier commented Jan 3, 2025

replaced the route /reconcile with /match and updated text to introduce the match service as the primary role of a reconciliation service. closes #186

@saumier saumier linked an issue Jan 3, 2025 that may be closed by this pull request
@saumier saumier requested a review from wetneb January 3, 2025 23:08
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for reconciliation-api-specs ready!

Name Link
🔨 Latest commit 695e2ad
🔍 Latest deploy log https://app.netlify.com/sites/reconciliation-api-specs/deploys/678004a64a43aa0008ecf226
😎 Deploy Preview https://deploy-preview-187--reconciliation-api-specs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

1.0-draft/index.html Outdated Show resolved Hide resolved
Co-authored-by: Antonin Delpeuch <[email protected]>
@saumier saumier requested a review from fsteeg January 4, 2025 16:16
@saumier saumier changed the title 186 confusing reconciliation route for reconciliation service 186 confusing reconcile route for reconciliation service Jan 4, 2025
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The match terminology fits in well with existing concepts and fields like matching features, matchType, matchQuantifier, matchQualifier etc. Added one inline suggestion to change the header for the service section.

1.0-draft/index.html Outdated Show resolved Hide resolved
Renamed to section to Match Service

Co-authored-by: Fabian Steeg <[email protected]>
@saumier saumier requested a review from fsteeg January 9, 2025 17:19
@fsteeg fsteeg merged commit 6661975 into master Jan 10, 2025
5 checks passed
@fsteeg fsteeg deleted the 186-confusing-reconciliation-route-for-reconciliation-service branch January 10, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing /reconciliation route for reconciliation service
3 participants