Orm querybuilder set parameters to collection #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelthole
commented
Jul 10, 2024
| @@ -163,6 +164,6 @@ private function isNullableJoinColumn(Property $property): bool | |||
| self::JOIN_COLUMN, | |||
| 'nullable' | |||
| ); | |||
| return $joinExpr instanceof Expr\ConstFetch && ! in_array('false', $joinExpr->name->getParts(), true); | |||
| return $joinExpr instanceof ConstFetch && ! in_array('false', $joinExpr->name->getParts(), true); | |||
There was a problem hiding this comment.
oh this change was not planed. I guess the composer fix-cs changed this
samsonasik
reviewed
Aug 30, 2024
rules/Orm30/Rector/MethodCall/SetParametersArrayToCollectionRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 30, 2024
samsonasik
reviewed
Aug 30, 2024
|
Hi. I was about to get cracking on this and saw your PR @marcelthole 👍 It would be nice if you could transform the following: $params = ['name' => 'John'];
if ($someCondition) {
$qb->andWhere('age > :age');
$params['age'] = 18;
}
$qb->setParameters($params);into $params = new ArrayCollection([new Parameter('name', 'John')]);
if ($someCondition) {
$qb->andWhere('age > :age');
$params->add(new Parameter('age', 18));
}
$qb->setParameters($params); |
marcelthole
force-pushed
the
orm-querybuilder-setParameters-to-collection
branch
from
220fe57
to
23348db
Compare
|
@JoolsMcFly i like the idea and created a second PR for that here: #346 |
samsonasik
reviewed
Sep 19, 2024
| @@ -0,0 +1,27 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
please add namespace like other fixture, non-namespaced fixture usually only on specific usecase
samsonasik
reviewed
Sep 19, 2024
| */ | ||
| public function refactor(Node $node): Node|null | ||
| { | ||
| assert($node instanceof MethodCall); |
There was a problem hiding this comment.
assert is not needed
Suggested change
| assert($node instanceof MethodCall); |
…ection for the setParameters ORM QueryBuilder method
marcelthole
force-pushed
the
orm-querybuilder-setParameters-to-collection
branch
from
23348db
to
b2f4a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey,
i have a new feature proposal for changing the method signature for
Doctrine\ORM\QueryBuilder::setParametersfrom the array type from Doctrine ORM 2.x to the ArrayCollection with Parameter type of ORM 3.xsee doctrine/orm#9490
see https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md#query-querybuilder-and-nativequery-parameters-bc-break