improvement: check response always, not only through makeRequest #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Base client class now accepts Http Adapter object as param. - Add http adapter interface
… into v3-v2021-02-25: - Added HttpAdapterInterface
…t-Type: application/json" was received in header.
so that makeRequest AND pagerCount are validated.
… because toResource no longer throws errors - makeRequest does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing makeRequest, request were undergoing proper validation, and could throw errors.
In pagerCount, though, _getResponse was not followed by toResource, so it was not validated, even if the HEAD response had an erroneous status code.
This patch makes bad HEAD responses (like: invalid API key) throw errors just like any other response.
Requires my previous PR (validation of headers even in json-without-body case) to work properly.