Merged
Conversation
Collaborator
|
I think that a minimum of 0 should be the default, yes. As you'll never have a negative length string/buffer/array etc. |
sasial-dev
approved these changes
Mar 2, 2025
Collaborator
sasial-dev
left a comment
sasial-dev
left a comment
There was a problem hiding this comment.
Other than this comment, LGTM
Co-authored-by: Sasial <44125644+sasial-dev@users.noreply.github.com>
Collaborator
|
Thank you! |
daimond113
added a commit
to daimond113/zap
that referenced
this pull request
Mar 15, 2025
sasial-dev
pushed a commit
that referenced
this pull request
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing lengths was hardcoded to u16, even when a different type would be better. So, now if the range of length is known it'll be used to serialize the length in the fitting size.
This currently requires explicit minimum values (
0..255). Should a minimum of 0 be default?