Skip to content

Support quoted identifiers with spaces#169

Merged
sasial-dev merged 4 commits intored-blox:0.6.xfrom
daimond113:feat/quoted-identifiers
Mar 7, 2025
Merged

Support quoted identifiers with spaces#169
sasial-dev merged 4 commits intored-blox:0.6.xfrom
daimond113:feat/quoted-identifiers

Conversation

@daimond113
Copy link
Copy Markdown
Contributor

@daimond113 daimond113 commented Mar 2, 2025

Adds support to quoting identifiers which are:

  • keys of structs
  • keys of tagged enums
  • values of unit enums

Quoted identifiers are useful because they're allowed to contain spaces.

Additionally, fixes the types for tags of enums containing spaces.

Copy link
Copy Markdown
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@daimond113 daimond113 requested a review from sasial-dev March 6, 2025 22:43
Copy link
Copy Markdown
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sasial-dev
Copy link
Copy Markdown
Collaborator

Thank you!

@sasial-dev sasial-dev merged commit ac637ed into red-blox:0.6.x Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants