Fix IsServer/IsClient checking#215
Merged
sasial-dev merged 5 commits intored-blox:0.6.xfrom Dec 13, 2025
Merged
Conversation
Collaborator
|
Thanks - that's a great idea. |
Contributor
Author
|
Reverted, I think it was because of my auto formatting 👍 |
Collaborator
|
CI has failed but that's not your fault!!! It will be due to the rust version that just released today... https://blog.rust-lang.org/2025/12/11/Rust-1.92.0/ |
Collaborator
|
@tacheometry - did you test your output changes locally? The tests have picked up that |
Contributor
Author
|
Check if it's alright |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsServer/IsClient should be checked before the remote scope validation.
If you accidentally require the client module on the server, the remote scope validation triggers first. Then, you can only figure out that you required the wrong module by yourself, the error doesn't indicate the most important problem.