Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Remove a trailing , #302

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

tikkss
Copy link
Contributor

@tikkss tikkss commented Mar 17, 2025

Because of a syntax error. Missed in 4ee58e7.

Because of a syntax error. Missed in 4ee58e7.
@tikkss
Copy link
Contributor Author

tikkss commented Mar 17, 2025

Ubuntu CI are failed. but I think does not relate to this change.

It seems that an error occurred while installing gobject-introspection (4.2.7):

https://github.com/red-data-tools/red_amber/actions/runs/13909948160/job/38921777526?pr=302#step:5:155

Fetching gobject-introspection 4.2.7
Installing gobject-introspection 4.2.7 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/home/runner/work/red_amber/red_amber/vendor/bundle/ruby/3.1.0/gems/gobject-introspection-4.2.7/ext/gobject-introspection
/opt/hostedtoolcache/Ruby/3.1.6/x64/bin/ruby -I
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0 extconf.rb
checking for --enable-debug-build option... no
checking for -Wall option to compiler... yes
checking for -Wcast-align option to compiler... yes
checking for -Wextra option to compiler... yes
checking for -Wformat=2 option to compiler... yes
checking for -Winit-self option to compiler... yes
checking for -Wlarger-than-65500 option to compiler... yes
checking for -Wmissing-declarations option to compiler... yes
checking for -Wmissing-format-attribute option to compiler... yes
checking for -Wmissing-include-dirs option to compiler... yes
checking for -Wmissing-noreturn option to compiler... yes
checking for -Wmissing-prototypes option to compiler... yes
checking for -Wnested-externs option to compiler... yes
checking for -Wold-style-definition option to compiler... yes
checking for -Wpacked option to compiler... yes
checking for -Wp,-D_FORTIFY_SOURCE=2 option to compiler... no
checking for -Wpointer-arith option to compiler... yes
checking for -Wundef option to compiler... yes
checking for -Wout-of-line-declaration option to compiler... no
checking for -Wunsafe-loop-optimizations option to compiler... yes
checking for -Wwrite-strings option to compiler... yes
checking for Homebrew... no
checking for gobject-introspection-1.0... yes (1.80.1)
creating rbgiversion.h
creating gobject-introspection-enum-types.c
creating gobject-introspection-enum-types.h
creating ruby-gobject-introspection.pc
creating Makefile

current directory:
/home/runner/work/red_amber/red_amber/vendor/bundle/ruby/3.1.0/gems/gobject-introspection-4.2.7/ext/gobject-introspection
make DESTDIR\= sitearchdir\=./.gem.20250317-4099-3xc0dd
sitelibdir\=./.gem.20250317-4099-3xc0dd clean

current directory:
/home/runner/work/red_amber/red_amber/vendor/bundle/ruby/3.1.0/gems/gobject-introspection-4.2.7/ext/gobject-introspection
make DESTDIR\= sitearchdir\=./.gem.20250317-4099-3xc0dd
sitelibdir\=./.gem.20250317-4099-3xc0dd
compiling gobject-introspection-enum-types.c
gobject-introspection-enum-types.c:5:10: fatal error: girepository.h: No such
file or directory
    5 | #include <girepository.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:247: gobject-introspection-enum-types.o] Error 1

make failed, exit code 2

Gem files will remain installed in
/home/runner/work/red_amber/red_amber/vendor/bundle/ruby/3.1.0/gems/gobject-introspection-4.2.7
for inspection.
Results logged to
/home/runner/work/red_amber/red_amber/vendor/bundle/ruby/3.1.0/extensions/x86_64-linux/3.1.0/gobject-introspection-4.2.7/gem_make.out

/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:102:in
`run'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:51:in
`block in make'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:43:in
`each'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:43:in
`make'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/ext_conf_builder.rb:42:in
`build'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:171:in
`build_extension'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:205:in
`block in build_extensions'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:202:in
`each'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/ext/builder.rb:202:in
`build_extensions'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/rubygems/installer.rb:843:in
`build_extensions'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/rubygems_gem_installer.rb:72:in
`build_extensions'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/rubygems_gem_installer.rb:28:in
`install'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/source/rubygems.rb:207:in
`install'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/installer/gem_installer.rb:54:in
`install'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/installer/gem_installer.rb:16:in
`install_from_spec'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/installer/parallel_installer.rb:186:in
`do_install'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/installer/parallel_installer.rb:177:in
`block in worker_pool'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/worker.rb:62:in
`apply_func'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/worker.rb:57:in
`block in process_queue'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/worker.rb:54:in
`loop'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/worker.rb:54:in
`process_queue'
/opt/hostedtoolcache/Ruby/3.1.6/x64/lib/ruby/3.1.0/bundler/worker.rb:91:in
`block (2 levels) in create_threads'

An error occurred while installing gobject-introspection (4.2.7), and Bundler
cannot continue.

In Gemfile:
  red-arrow-numo-narray was resolved to 0.0.6, which depends on
    red-arrow was resolved to 19.0.1, which depends on
      gio2 was resolved to 4.2.7, which depends on
        gobject-introspection
Error: The process '/opt/hostedtoolcache/Ruby/3.1.6/x64/bin/bundle' failed with exit code 5

@kou kou merged commit 9e3fcbd into red-data-tools:main Mar 18, 2025
4 of 10 checks passed
@kou
Copy link
Member

kou commented Mar 18, 2025

Good catch!

Let's fix CI as a separated task.

@tikkss
Copy link
Contributor Author

tikkss commented Mar 18, 2025

Let's fix CI as a separated task.

OK! Thanks for your review.

@tikkss tikkss deleted the remove-a-trailing-comma branch March 18, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants