Skip to content

chore: drop maxdepth from CI lockfile check and add mcp_automl_template hook#182

Open
tarun-etikala wants to merge 1 commit into
red-hat-data-services:mainfrom
tarun-etikala:fix/ci-lockfile-find-depth
Open

chore: drop maxdepth from CI lockfile check and add mcp_automl_template hook#182
tarun-etikala wants to merge 1 commit into
red-hat-data-services:mainfrom
tarun-etikala:fix/ci-lockfile-find-depth

Conversation

@tarun-etikala

Copy link
Copy Markdown
Contributor

Description

Two fixes from review feedback on #179:

  • Drop maxdepth 5 from CI lockfile-check find command. The templates/ restructure pushed mcp_automl_template to depth 6, causing CI to silently skip it. Removing maxdepth makes the check future-proof — path exclusions (.venv, egg-info) already filter noise.
  • Add missing pre-commit hook for agents/autogen/templates/mcp_agent/mcp_automl_template/ — the only pyproject.toml without a uv-lock pre-commit entry.

Jira Ticket

RHAIENG-4059

Testing

  • make test passes (run from the affected agent directory)
  • Manual testing performed (describe steps below)
  • No testing required (documentation/config change only)

pre-commit run uv-lock --all-files — all 13 entries pass (including new mcp_automl_template).

Checklist

  • I have read CONTRIBUTING.md
  • No .env or secret files are included in this PR
  • All changes are within scope of the linked Jira ticket (if not, explain in Description)

Related PRs

🤖 Generated with Claude Code

…te hook

Remove hardcoded maxdepth from find in lockfile-check CI job so it
discovers pyproject.toml files at any nesting depth. The path exclusions
(.venv, egg-info) already filter noise.

Also add missing uv-lock pre-commit entry for mcp_automl_template
sub-project.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 968b6f74-d736-4e43-a5e2-ce71bd42f4a0

📥 Commits

Reviewing files that changed from the base of the PR and between ba5c5a4 and cd8029e.

📒 Files selected for processing (2)
  • .github/workflows/code-quality.yml
  • .pre-commit-config.yaml

📝 Walkthrough

Walkthrough

The pull request broadens lockfile dependency verification by removing the directory depth limit in the CI workflow's find command, and adds a pre-commit hook to keep the mcp_automl_template project's lockfile synchronized with its updated dependencies.

Changes

Lockfile Configuration Updates

Layer / File(s) Summary
CI lockfile verification scope
.github/workflows/code-quality.yml
The find command for the lockfile-check job removes the -maxdepth 5 limit, expanding the directory search to cover all nested pyproject.toml files.
Template project pre-commit hook
.pre-commit-config.yaml
A new uv-lock hook is added for the mcp_automl_template template, specifying its project path and pyproject.toml file pattern to ensure lockfile consistency.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes both main changes: removing maxdepth limitation and adding the mcp_automl_template hook.
Description check ✅ Passed The description clearly relates to the changeset, explaining the rationale for both modifications and providing context from review feedback.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant