feat: add actionlint to CI and pre-commit for workflow validation#89
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds Actionlint to CI and local tooling: the Code Quality workflow now runs an ChangesLinting Tooling & CI Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
5f9aa0a to
047a830
Compare
Add actionlint step to the Code Quality CI workflow using SHA-pinned raven-actions/actionlint action (v2.1.2, actionlint 1.7.12). Add actionlint hook to .pre-commit-config.yaml with files filter for .github/workflows/. Document actionlint in CONTRIBUTING.md under Pre-commit hooks and Linting sections. Ref: RHAIENG-4067 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bd91e5c to
953cb5e
Compare
The Linting section duplicated install/run instructions already covered by the Pre-commit hooks section. Replace with a reference to pre-commit hooks and a config file summary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Description
Add actionlint to the CI pipeline and pre-commit configuration to validate GitHub Actions workflow files, completing the workflow validation scope of RHAIENG-4067.
Changes:
Code QualityCI workflow using SHA-pinnedraven-actions/actionlintaction (v2.1.2, actionlint binary v1.7.12).pre-commit-config.yamlwithfiles: ^\.github/workflows/filterCONTRIBUTING.mdunder Pre-commit hooks and Linting sectionsCONTRIBUTING.md(now covered by pre-commit hooks)Jira Ticket
RHAIENG-4067
Testing
make testpasses (run from the affected agent directory)Verified locally:
actionlintpasses on all existing workflow files with zero violationspre-commit run actionlint --all-filespassesChecklist
.envor secret files are included in this PRReview Guidance
code-quality.yml: actionlint step uses SHA-pinned action with explicit binary version pinned to match pre-commit.pre-commit-config.yaml: actionlint hook only runs when.github/workflows/files are stagedCONTRIBUTING.md: removed redundant manual ruff/markdownlint instructions (pre-commit handles them), added actionlint to Pre-commit hooks section and Linting introRelated PRs