-
Notifications
You must be signed in to change notification settings - Fork 12
chore: add ruff, markdownlint, and file-hygiene pre-commit hooks #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2283,4 +2283,4 @@ | |
| "action_name": null, | ||
| "action_description": null, | ||
| "access_type": "PRIVATE" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,3 @@ | ||||||
| MIT License | ||||||
|
|
||||||
| Copyright (c) 2026 | ||||||
| Copyright (c) 2026 | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing copyright holder name in MIT License. The copyright line specifies only the year but omits the copyright holder's name. The MIT License requires the format Add the appropriate copyright holder name (e.g., "Red Hat, Inc." or the relevant entity) to complete the license declaration and ensure legal compliance. 📋 Suggested fix-Copyright (c) 2026
+Copyright (c) 2026 Red Hat, Inc.📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -423,4 +423,4 @@ | |
| </script> | ||
|
|
||
| </body> | ||
| </html> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,4 @@ __pycache__ | |
| .venv | ||
| dist | ||
| config.toml | ||
| inference_engine_cache/ | ||
| inference_engine_cache/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -440,4 +440,4 @@ | |
| </script> | ||
|
|
||
| </body> | ||
| </html> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,3 @@ | ||||||
| MIT License | ||||||
|
|
||||||
| Copyright (c) 2026 | ||||||
| Copyright (c) 2026 | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing copyright holder name in MIT License. The copyright line specifies only the year but omits the copyright holder's name. The MIT License requires the format Add the appropriate copyright holder name (e.g., "Red Hat, Inc." or the relevant entity) to complete the license declaration and ensure legal compliance. 📋 Suggested fix-Copyright (c) 2026
+Copyright (c) 2026 Red Hat, Inc.📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -423,4 +423,4 @@ | |
| </script> | ||
|
|
||
| </body> | ||
| </html> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,3 @@ | ||||||
| MIT License | ||||||
|
|
||||||
| Copyright (c) 2026 | ||||||
| Copyright (c) 2026 | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing copyright holder name in MIT License. The copyright line specifies only the year but omits the copyright holder's name. The MIT License requires the format Add the appropriate copyright holder name (e.g., "Red Hat, Inc." or the relevant entity) to complete the license declaration and ensure legal compliance. 📋 Suggested fix-Copyright (c) 2026
+Copyright (c) 2026 Red Hat, Inc.📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -423,4 +423,4 @@ | |
| </script> | ||
|
|
||
| </body> | ||
| </html> | ||
| </html> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: move file-hygiene hooks before ruff/markdownlint
Convention is to put the fast normalizers (
trailing-whitespace,end-of-file-fixer, etc.) before language-specific linters so they see already-clean files. With the current order, if a Python file has trailing whitespace, both ruff andtrailing-whitespacetry to fix it — potentially causing a confusing double-modification on the first run.Suggested repo order in the config: