Skip to content

fix(langflow): document rootful workaround and remove duplicate .env.example#96

Merged
sanafayyaz315 merged 2 commits into
red-hat-data-services:mainfrom
sanafayyaz315:testing
May 13, 2026
Merged

fix(langflow): document rootful workaround and remove duplicate .env.example#96
sanafayyaz315 merged 2 commits into
red-hat-data-services:mainfrom
sanafayyaz315:testing

Conversation

@sanafayyaz315
Copy link
Copy Markdown
Contributor

@sanafayyaz315 sanafayyaz315 commented May 12, 2026

Description

Fix two Langflow agent bugs found during full test run:

  1. Podman rootless bind-mount errormake run can fail on macOS with statfs ... init-db.sh: operation not permitted due to rootless Podman not being able to bind-mount host files. Added a callout in the README with the podman machine set --rootful workaround.
  2. Duplicate .env.examplelocal/.env.example was never used by any make target (make init copies the root .env.example). Removed the orphaned file to avoid confusion.

Jira Ticket

https://redhat.atlassian.net/browse/RHAIENG-5047
https://redhat.atlassian.net/browse/RHAIENG-5058

Testing

  • make test passes (no tests for this agent)
  • No testing required (documentation/config change only)

Checklist

  • I have read CONTRIBUTING.md
  • No .env or secret files are included in this PR
  • All changes are within scope

Review Guidance

Two small changes — README diff and one deleted file.

Related PRs

None

…example

Add a callout to the README for the Podman rootless bind-mount error
(statfs: operation not permitted) with the rootful workaround. Remove
the orphaned local/.env.example that was never used by any make target.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 6f9a5491-0cf8-49d8-a6d2-037fc0a9f706

📥 Commits

Reviewing files that changed from the base of the PR and between a99e8c0 and 0d8e1bb.

📒 Files selected for processing (1)
  • agents/langflow/simple_tool_calling_agent/README.md
✅ Files skipped from review due to trivial changes (1)
  • agents/langflow/simple_tool_calling_agent/README.md

📝 Walkthrough

Walkthrough

Added a macOS-specific Podman troubleshooting note to the local README to fix a Podman bind-mount permission error during make run. Removed all example environment variable entries from the local .env.example.

Changes

macOS Podman Troubleshooting Documentation

Layer / File(s) Summary
Troubleshooting note for Podman permission issue
agents/langflow/simple_tool_calling_agent/README.md
Inserted lines describing a macOS-specific fix for statfs ... init-db.sh: operation not permitted when running make run: commands to stop the Podman machine, set it to --rootful, restart it, rerun make run, and an optional note on reverting the machine to rootless afterward.

Environment Configuration Cleanup

Layer / File(s) Summary
Example environment variables removal
agents/langflow/simple_tool_calling_agent/local/.env.example
Removed all example environment variable entries (approximately 11 lines), including PostgreSQL connection defaults, Langfuse admin password/encryption key placeholders, and the default Ollama model placeholder.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes both main changes: documenting the rootful workaround for Podman and removing the duplicate .env.example file.
Description check ✅ Passed The description is directly related to the changeset, explaining both changes (Podman rootless bind-mount error documentation and removal of orphaned .env.example file) with context and references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@agents/langflow/simple_tool_calling_agent/README.md`:
- Around line 100-108: Add a short security warning to the macOS Podman rootful
instructions and append the rollback commands to return Podman to rootless mode
after setup; specifically update the macOS section containing the podman
sequence (the block with "podman machine stop", "podman machine set --rootful",
"podman machine start", "make run") to include a one-line caution about elevated
privileges and then show the rollback sequence using "podman machine stop",
"podman machine set --rootful=false", and "podman machine start".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 1f8d767e-da15-4268-9aac-0d8156a21f2e

📥 Commits

Reviewing files that changed from the base of the PR and between 6be61b4 and a99e8c0.

📒 Files selected for processing (2)
  • agents/langflow/simple_tool_calling_agent/README.md
  • agents/langflow/simple_tool_calling_agent/local/.env.example
💤 Files with no reviewable changes (1)
  • agents/langflow/simple_tool_calling_agent/local/.env.example

Comment thread agents/langflow/simple_tool_calling_agent/README.md Outdated
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@tarun-etikala tarun-etikala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sanafayyaz315 sanafayyaz315 merged commit 8e056ed into red-hat-data-services:main May 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants