Wznoinsk main modify pull request pipeline#46
Conversation
…konflux_config add renovate.json
| build.appstudio.redhat.com/pull_request_number: "{{pull_request_number}}" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-comment: "^/build-konflux odh-ai-gateway-payload-processing" | ||
| pipelinesascode.tekton.dev/on-target-branch: "[{{target_branch}}]" |
There was a problem hiding this comment.
why are we removing these annotations?
There was a problem hiding this comment.
oh, i see the commit message. @wznoinsk can you restore/set the annotations to somthing like this -
pipelinesascode.tekton.dev/on-comment: "^/build-konflux odh-ai-gateway-payload-processing"
pipelinesascode.tekton.dev/on-label: "[kfbuild-all, kfbuild-ai-gateway-payload-processing]"
pipelinesascode.tekton.dev/on-target-branch: "[{{target_branch}}]"
pipelinesascode.tekton.dev/on-event: "[pull_request]"
this would allow devs to set a label on certain PRs that they want to have pr runs on any new commits to that PR
| build.appstudio.redhat.com/pull_request_number: "{{pull_request_number}}" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-comment: "^/build-konflux odh-ai-gateway-payload-processing" | ||
| pipelinesascode.tekton.dev/on-target-branch: "[{{target_branch}}]" |
There was a problem hiding this comment.
oh, i see the commit message. @wznoinsk can you restore/set the annotations to somthing like this -
pipelinesascode.tekton.dev/on-comment: "^/build-konflux odh-ai-gateway-payload-processing"
pipelinesascode.tekton.dev/on-label: "[kfbuild-all, kfbuild-ai-gateway-payload-processing]"
pipelinesascode.tekton.dev/on-target-branch: "[{{target_branch}}]"
pipelinesascode.tekton.dev/on-event: "[pull_request]"
this would allow devs to set a label on certain PRs that they want to have pr runs on any new commits to that PR
|
@ckhordiasma Konflux-User-Advisor notebooklm says: I'm removing these labels becuase we have konflux pull request pipeline triggered for each of the PRs https://github.com/red-hat-data-services/ai-gateway-payload-processing/pulls which is a lot of workload. |
if you add on-label, it will not trigger on every pull request. only the ones that have the matching labels. https://pipelinesascode.com/docs/guides/event-matching/comment-and-label/#matching-on-pull-request-labels as a test, you can add it to this PR, and you should not get a pull request pipeline on this PR because we don't have that label attached to the PR |
|
also - refer to red-hat-data-services/konflux-central#1733 |
|
ever single pull request https://github.com/red-hat-data-services/ai-gateway-payload-processing/pulls (I did check the chore ones quick) had konflux internal running pull-request pipeline - definitively that's something we don't want to do, if on-event has to be set along with on-label and if on-event itself is triggering pull request pipelines already then that (on-label thing) is something we probably don't wnat to enable |
2 participants
No description provided.