chore: Update Dockerfiles to use Go toolset 1.26.3 and native Go FIPS 140 configuration in Konflux Dockerfiles - #705
Merged
alyssacgoins merged 1 commit intoJun 24, 2026
Conversation
Author
|
/hold |
… 140 configuration in Konflux Dockerfiles
alyssacgoins
approved these changes
Jun 24, 2026
|
|
||
| RUN --mount=type=cache,target=/go/pkg/mod --mount=type=cache,target=/root/.cache/go-build GIT_COMMIT=${GIT_COMMIT} GIT_TAG=${GIT_TAG} GIT_TREE_STATE=${GIT_TREE_STATE} CGO_ENABLED=1 GOEXPERIMENT=strictfipsruntime go build -tags strictfipsruntime -v -o dist/argoexec-fips ./cmd/argoexec | ||
| RUN --mount=type=cache,target=/go/pkg/mod --mount=type=cache,target=/root/.cache/go-build GIT_COMMIT=${GIT_COMMIT} GIT_TAG=${GIT_TAG} GIT_TREE_STATE=${GIT_TREE_STATE} CGO_ENABLED=0 go build -ldflags '-extldflags -static' -v -o dist/argoexec ./cmd/argoexec | ||
| RUN --mount=type=cache,target=/go/pkg/mod --mount=type=cache,target=/root/.cache/go-build GIT_COMMIT=${GIT_COMMIT} GIT_TAG=${GIT_TAG} GIT_TREE_STATE=${GIT_TREE_STATE} CGO_ENABLED=0 GOTOOLCHAIN=local GOFIPS140=v1.0.0 go build -tags no_openssl -ldflags '-extldflags -static' -v -o dist/argoexec ./cmd/argoexec |
There was a problem hiding this comment.
just curious: why did you combine these two lines into one here?
Author
There was a problem hiding this comment.
It was two different files:
-o dist/argoexec-fips
-o dist/argoexec
Now it's only the latter.
alyssacgoins
merged commit Jun 24, 2026
017ed13
into
red-hat-data-services:rhoai-3.5
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOEXPERIMENT=strictfipsruntimedual-binary to nativeGOFIPS140=v1.0.0single binaryargoexec-fipsartifact (no longer needed)Jira: https://redhat.atlassian.net/browse/RHOAIENG-70533