Skip to content

Build binaries in FIPS compliant manner#234

Merged
grdryn merged 1 commit intored-hat-data-services:mainfrom
grdryn:design-for-fips
Apr 21, 2026
Merged

Build binaries in FIPS compliant manner#234
grdryn merged 1 commit intored-hat-data-services:mainfrom
grdryn:design-for-fips

Conversation

@grdryn
Copy link
Copy Markdown

@grdryn grdryn commented Apr 20, 2026

JIRA: https://redhat.atlassian.net/browse/RHOAIENG-58628

Description

Fix check-payload failures

Testing

  • Unit tests pass (make test)
  • Linter passes (make lint)
  • New functionality includes tests

PR build shows that check-payload failures are fixed:

➜ podman unshare ~/src/github.com/openshift/check-payload/check-payload scan image --spec quay.io/rhoai/pull-request-pipelines:odh-cli-480b965362a6478f8805d72c2be57a6b424604d5
I0421 01:12:53.110459   67403 main.go:313] using embedded config
I0421 01:12:53.110703   67403 main.go:102] "scan" version="0.3.10-8-g3944a920"
---- Successful run

Review checklist

  • Code follows project conventions (see docs/coding/)
  • Changes are documented if needed

@grdryn
Copy link
Copy Markdown
Author

grdryn commented Apr 20, 2026

/build-konflux

@grdryn
Copy link
Copy Markdown
Author

grdryn commented Apr 20, 2026

@ckhordiasma Any idea what's going wrong with the Konflux PR job here? PR #235 seems to show that it's not related to the changes in this PR, and that maybe the job is otherwise broken?

@ckhordiasma
Copy link
Copy Markdown

there seems to be some kind of discrepancy between what the build wants and what hermeto is prefetching.. looking into it some more

@ckhordiasma
Copy link
Copy Markdown

all right, try rebasing with main, should be fixed now

@grdryn
Copy link
Copy Markdown
Author

grdryn commented Apr 21, 2026

/build-konflux

@grdryn
Copy link
Copy Markdown
Author

grdryn commented Apr 21, 2026

Changes effectively fix the check-payload failures:

➜ podman unshare ~/src/github.com/openshift/check-payload/check-payload scan image --spec quay.io/rhoai/pull-request-pipelines:odh-cli-480b965362a6478f8805d72c2be57a6b424604d5
I0421 01:12:53.110459   67403 main.go:313] using embedded config
I0421 01:12:53.110703   67403 main.go:102] "scan" version="0.3.10-8-g3944a920"
---- Successful run

@grdryn grdryn merged commit 92d4d7b into red-hat-data-services:main Apr 21, 2026
1 of 2 checks passed
@grdryn grdryn deleted the design-for-fips branch April 21, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants