Skip to content

Fix: resolve KFP dependency conflict in knowledge-tuning pipeline#88

Merged
CathalOConnorRH merged 1 commit into
red-hat-data-services:mainfrom
CathalOConnorRH:fix/kfp-dependency-conflict
Jun 11, 2026
Merged

Fix: resolve KFP dependency conflict in knowledge-tuning pipeline#88
CathalOConnorRH merged 1 commit into
red-hat-data-services:mainfrom
CathalOConnorRH:fix/kfp-dependency-conflict

Conversation

@CathalOConnorRH

Copy link
Copy Markdown
Contributor

Summary

  • Bump kfp and kfp-kubernetes from 2.15.2 to >=2.16.1 in the knowledge-tuning Kubeflow pipeline
  • Resolves a pip dependency conflict where kfp-components@main requires kfp>=2.16.1 while the pipeline pinned kfp==2.15.2
  • Fixes the failing Validation & Tests CI job (test_venv_builds_cleanly in tests/validation/test_pyproject_toml.py)

Test plan

  • Verified locally: pip install --dry-run -e examples/knowledge-tuning/Kubeflow_Pipeline resolves cleanly to kfp-2.16.1, kfp-kubernetes-2.16.1, and kfp-components-1.11.0
  • CI Notebook Tests workflow passes

Bump kfp and kfp-kubernetes to >=2.16.1 so pip can resolve kfp-components@main, which unblocks the Notebook Tests CI validation.
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: e30845a7-6417-4613-b25f-bdfdb3c86cde

📥 Commits

Reviewing files that changed from the base of the PR and between cf7d084 and 1032fa5.

📒 Files selected for processing (2)
  • examples/knowledge-tuning/Kubeflow_Pipeline/README.md
  • examples/knowledge-tuning/Kubeflow_Pipeline/pyproject.toml

📝 Walkthrough

Walkthrough

The Kubeflow Pipeline example dependencies are updated to require minimum versions of kfp and kfp-kubernetes at 2.16.1. Both the project configuration and installation documentation reflect this constraint change consistently.

Changes

Kubeflow Pipeline dependency version updates

Layer / File(s) Summary
Kubeflow Pipeline dependency version constraints
examples/knowledge-tuning/Kubeflow_Pipeline/README.md, examples/knowledge-tuning/Kubeflow_Pipeline/pyproject.toml
Installation documentation and project dependencies are updated to require kfp>=2.16.1 and kfp-kubernetes>=2.16.1, replacing prior pinned (==2.15.2) and minimum (>=2.15.2) version constraints.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating KFP dependencies to resolve a pip dependency conflict in the knowledge-tuning pipeline.
Description check ✅ Passed The description is directly related to the changeset, clearly explaining the dependency version bumps and the specific CI issue being resolved.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@szaher szaher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CathalOConnorRH CathalOConnorRH merged commit 2e960d2 into red-hat-data-services:main Jun 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants