Skip to content

Skip TestDefaultBackingstoreOverride in external deployments #12066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip TestDefaultBackingstoreOverride in external deployments #12066

wants to merge 1 commit into from

Conversation

sagihirshfeld
Copy link
Contributor

This test suite attempts to clone the existing default backingstore and set the clone as the new default.

In external deployments, this process requires additional configuration steps that add complexity without meaningful benefit. This PR skips these scenarios to streamline the test flow and avoid spending time on a low-value edge case.

@sagihirshfeld
Skip in external deployments
952f4e4 
Signed-off-by: Sagi Hirshfeld <[email protected]>
@sagihirshfeld sagihirshfeld added MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels May 5, 2025
@sagihirshfeld sagihirshfeld self-assigned this May 5, 2025
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner May 5, 2025 15:59
@sagihirshfeld
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Collaborator

@sagihirshfeld: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm label May 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld, suchita-g, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sagihirshfeld
Copy link
Contributor Author

Adding the Verified label due to the limited nature of the change

@sagihirshfeld sagihirshfeld added the Verified Mark when PR was verified and log provided label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vavuthu vavuthu vavuthu approved these changes

@suchita-g suchita-g suchita-g approved these changes

@keesturam keesturam Awaiting requested review from keesturam

@udaysk23 udaysk23 Awaiting requested review from udaysk23

@ypersky1980 ypersky1980 Awaiting requested review from ypersky1980

At least 2 approving reviews are required to merge this pull request.

Assignees

@sagihirshfeld sagihirshfeld

@vavuthu vavuthu

@suchita-g suchita-g

Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/XS Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sagihirshfeld @openshift-cherrypick-robot @vavuthu @suchita-g