fix existing yaml configs with nodepool replicas #12086
Conversation
Signed-off-by: Daniel Osypenko <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the deployment job expected the variable "nodepool_replicas" instead of "worker_replicas" and updates the associated YAML configuration files accordingly.
- Replaces "worker_replicas" with "nodepool_replicas" in two configuration files to ensure the intended value is used.
- Aligns the configuration variable with the deployment job's expectations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conf/deployment/fusion_hci_pc/client_bm_upi_1az_rhcos_nvme_3w.yaml | Replaces "worker_replicas" (3) with "nodepool_replicas" (3) |
| conf/deployment/fusion_hci_pc/client_bm_upi_1az_rhcos_nvme_2w.yaml | Replaces "worker_replicas" (2) with "nodepool_replicas" (2) |
Comments suppressed due to low confidence (2)
conf/deployment/fusion_hci_pc/client_bm_upi_1az_rhcos_nvme_3w.yaml:7
- The variable name change to 'nodepool_replicas' aligns with the expected parameter in the deployment job. Consider updating any related documentation or comments in the file to reflect this change.
nodepool_replicas: 3
conf/deployment/fusion_hci_pc/client_bm_upi_1az_rhcos_nvme_2w.yaml:7
- The change from 'worker_replicas' to 'nodepool_replicas' properly fixes the parameter being used by the deployment job. It would be beneficial to verify that the naming is consistently updated across the related deployment documentation.
nodepool_replicas: 2
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak, DanielOsypenko, fbalak, jilju, suchita-g The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nodepool_replicaswere not used andworker_replicasused instead, when deployment job expected to getnodepool_replicas, hence default value '2' always takes place