Skip to content

Conversation

@AviadP
Copy link
Contributor

@AviadP AviadP commented Dec 22, 2025

  • Deleted global variable _FAILURE_DOMAINS
  • Added new method: _get_failure_domains_from_storagecluster()
  • Modified get_failure_domains() with priority fallback

Sometimes failure domains queried before blockpools are ready, which cause

        # Call setup function directly
        storage_cluster = self.replica1_setup()
        failure_domains = get_failure_domains()
        testing_pod = create_pod_on_failure_domain(
            project_factory,
>           failure_domain=failure_domains[0],
        )
E       IndexError: list index out of range

tests/functional/storageclass/test_replica1.py:328: IndexError

@AviadP AviadP requested a review from a team as a code owner December 22, 2025 14:10
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Dec 22, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

replica-1 size/M PR that changes 30-99 lines Squad/Brown

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant