-
Notifications
You must be signed in to change notification settings - Fork 186
Verifying liveness and readiness probes of OCS & MCG operator (Happy Path) #13992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: selwin.s <[email protected]> updated comments Signed-off-by: selwin.s <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: s-selwin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ocs-ci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: sels-22dec-21
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/monitoring/test_operator_probe_resilience.py
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master
Signed-off-by: selwin.s <[email protected]>
Signed-off-by: selwin.s <[email protected]>
Signed-off-by: selwin.s <[email protected]>
Signed-off-by: selwin.s <[email protected]>
ocs-ci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: sels-22dec-21
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/monitoring/test_operator_probe_resilience.py
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master
| logger.info(f"Patching {self.csv_name} {probe_type} to: {path_value}") | ||
| self.csv_obj.patch(params=patch_list, format_type="json") | ||
|
|
||
| def test_probe_resilience(self, probe_type, healthy_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docstrings for the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| ) | ||
| if statuses and not statuses[0].get("ready"): | ||
| logger.info( | ||
| f"Confirmed: Pod {p.name} is Running but NotReady." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The state can be different than Running. The docstring should reflect it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handled
| ] | ||
|
|
||
|
|
||
| @tier1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more like tier2 or tier4c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated tier for the testcase
Signed-off-by: selwin.s <[email protected]>
As part of new testcase - test_operator_probe_resilience.py, we will be performing the below steps
JIRA: https://issues.redhat.com/browse/OCSQE-4029