Changed the fixture scope from "session" to "class" in the TestCephtoolboxPod class. #14001
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olboxPod class. Signed-off-by: suchita-g <[email protected]> Test test after test_nodeaffinity_to_ceph_toolbox_with_default_taints are failing to schedule pods due to the presence of taint in the worker nodes. The test case adds the node taints but the finalizer removed the taint which has session scope. Changed the fixture scope from scope="session" to scope="class", The finalizer now runs after all tests in the TestCephtoolboxPod class complete
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: suchita-g The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test test after test_nodeaffinity_to_ceph_toolbox_with_default_taints are failing to schedule pods due to the presence of taint in the worker nodes. The test case adds the node taints but the finalizer removes the taint which has session scope.
Changed the fixture scope from scope="session" to scope="class", The finalizer now runs after all tests in the TestCephtoolboxPod class complete