Skip to content

Fix replica-1 test race condition and ensure teardown runs on failure #14110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AviadP wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix replica-1 test race condition and ensure teardown runs on failure #14110

AviadP wants to merge 1 commit into from

Conversation

@AviadP
Copy link
Contributor

@AviadP AviadP commented Jan 14, 2026 •
edited
Loading

  • Added wait_for_replica1_osds() function to poll until OSDs are created
  • Added ensure_cleanup fixture with request.addfinalizer()
  • Updated replica1_setup() to call wait_for_replica1_osds() after StorageCluster is ready

this PR should prevent issues such as #13242

@AviadP AviadP requested review from a team as code owners January 14, 2026 16:33
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jan 14, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

replica-1 size/M PR that changes 30-99 lines Squad/Brown

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AviadP