Skip to content

Label bucket logging PVC to exclude from leftover detection#14896

Draft
sagihirshfeld wants to merge 1 commit intored-hat-storage:masterfrom
sagihirshfeld:fix/label-bucket-logging-pvc-leftover
Draft

Label bucket logging PVC to exclude from leftover detection#14896
sagihirshfeld wants to merge 1 commit intored-hat-storage:masterfrom
sagihirshfeld:fix/label-bucket-logging-pvc-leftover

Conversation

@sagihirshfeld
Copy link
Copy Markdown
Contributor

@sagihirshfeld sagihirshfeld commented Apr 14, 2026

Summary

  • Label the noobaa-bucket-logging-pvc and its backing PV with custom=mcg-label in test_guaranteed_bucket_logs_management to exclude from leftover detection
  • Aligns with the pattern used in the enable_guaranteed_bucket_logging fixture for consistency

@sagihirshfeld @claude
Label bucket logging PVC to exclude from leftover detection
a6a7e9a 
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Sagi Hirshfeld <shirshfe@redhat.com>
@sagihirshfeld sagihirshfeld self-assigned this Apr 14, 2026
@sagihirshfeld sagihirshfeld added Needs Testing Run tests and provide logs link MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Apr 14, 2026
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Apr 14, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sagihirshfeld sagihirshfeld mentioned this pull request Apr 14, 2026
Draft
ocs-ci
ocs-ci reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-22ibm02
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_logs.py::TestBucketLogs::test_guaranteed_bucket_logs_management
Additional Test Params: --skip-rpm-go-version-collection
OCP VERSION: 4.22
OCS VERSION: 4.22
tested against branch: master

Job UNSTABLE (some or all tests failed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@sagihirshfeld sagihirshfeld

Labels

do-not-merge/work-in-progress MCG Multi Cloud Gateway / NooBaa related issues Needs Testing Run tests and provide logs link size/S PR that changes 10-29 lines Squad/Red

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sagihirshfeld @ocs-ci