Refactor IngressNodeFirewall deployment to use Operator base class#14902
Open
dahorak wants to merge 1 commit intored-hat-storage:masterfrom
Open
Refactor IngressNodeFirewall deployment to use Operator base class#14902dahorak wants to merge 1 commit intored-hat-storage:masterfrom
dahorak wants to merge 1 commit intored-hat-storage:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
dahorak
added
team/ecosystem
dahorak
force-pushed
the
fix-ingress-node-firewall-unreleased-deployment
branch
from
8784fe9 to
054322e
Compare
dahorak
force-pushed
the
fix-ingress-node-firewall-unreleased-deployment
branch
from
054322e to
5843dbd
Compare
Eliminates code duplication by replacing IngressNodeFirewallInstaller class with IngressNodeFirewallOperator that extends the Operator base class. This aligns the implementation with other operators (NMStateOperator, LocalStorageOperator, etc.) and automatically handles unreleased operator catalogs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Daniel Horak <dahorak@redhat.com>
dahorak
force-pushed
the
fix-ingress-node-firewall-unreleased-deployment
branch
from
5843dbd to
55edfc1
Compare
Contributor
Author
|
Verification job: https://url.corp.redhat.com/c8797e0 (version 4.22 is not yet available, so it installed version 4.21) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates code duplication by replacing IngressNodeFirewallInstaller class with IngressNodeFirewallOperator that extends the Operator base class. This aligns the implementation with other operators (NMStateOperator, LocalStorageOperator, etc.) and automatically handles unreleased operator catalogs.
This change should also fix the deployment of un-released version (e.g. on OCP 4.22).